I'm so sorry :( #262
I'm so sorry :( #262
Conversation
| return `${dinosaurs[i].name} (${dinosaurs[i].pronunciation})\n${dinosaurs[i].info} It lived in the ${dinosaurs[i].period} period, over ${dinosaurs[i].mya[dinosaurs[i].mya.length-1]} million years ago.` | ||
| } | ||
| }return `A dinosaur with an ID of '${id}' cannot be found.` | ||
| } |
There was a problem hiding this comment.
You have to put together a lot of information in a very specific way to get that string right. Well done!
| } | ||
| } dino[name] = length * 3.281 | ||
| }return dino | ||
| } |
There was a problem hiding this comment.
Well done!
I would highly recommend watching your code placement and indentation—placing code right after a bracket like that can make it very difficult ot tell what scope a line occurs in.
| function getDinosaursAliveMya(dinosaurs, mya, key) { | ||
| let dinosaursArray = [] | ||
| for (let i = 0; i < dinosaurs.length; i++) { | ||
| if ((mya <= dinosaurs[i].mya[0] && mya >= dinosaurs[i].mya[1]) || ((mya === dinosaurs[i].mya[0])) || (dinosaurs[i].mya - mya === 1)) { |
There was a problem hiding this comment.
Tough logic to handle. Well done! You clearly have thought a lot about how to combine conditions.
Same note as above regarding brackets. Especially with a nested if, like with this one!
| }else { | ||
| return `Dinosaur with name '${dinosaurName}' cannot be found in any rooms.` | ||
| } | ||
| } |
There was a problem hiding this comment.
Creative approach! Pushing them into a new array is a creative approach—it shows deep thought and experimentation. Keep it up!
Another readability principle to be conscious of: an if on the same line as the previous if's closing bracket is very easily misinterpreted as being logically connected, as with else if chains. Try to make your if placement reflect its job—form follows function.'
|
Aside from some readability tweaks to make, and those will come with practice. |
No description provided.