Milestones module development #343
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright 2016 Jon Ander Peñalba | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.github.mobile.api.service; | ||
|
|
||
| import com.github.mobile.api.model.Issue; | ||
| import com.github.mobile.api.model.Milestone; | ||
| import java.util.List; | ||
|
|
||
| import retrofit2.Call; | ||
| import retrofit2.http.Body; | ||
| import retrofit2.http.DELETE; | ||
| import retrofit2.http.GET; | ||
| import retrofit2.http.Headers; | ||
| import retrofit2.http.PATCH; | ||
| import retrofit2.http.POST; | ||
| import retrofit2.http.Path; | ||
| import retrofit2.http.Query; | ||
|
|
||
| public interface MilestoneService { | ||
| @GET("repos/{owner}/{repo}/milestones/{number}") | ||
| Call<Milestone> getMilestone( | ||
| @Path("owner") String owner, | ||
| @Path("repo") String repo, | ||
| @Path("number") long number); | ||
|
|
||
| @GET("repos/{owner}/{repo}/milestones") | ||
| Call<List<Milestone>> getMilestones( | ||
| @Path("owner") String owner, | ||
| @Path("repo") String repo); | ||
|
|
||
| @Headers("Accept: application/vnd.github.squirrel-girl-preview") | ||
| @GET("repos/{owner}/{repo}/issues") | ||
| Call<List<Issue>> getIssues( | ||
| @Path("owner") String owner, | ||
| @Path("repo") String repo, | ||
| @Query("milestone") long milestone); | ||
|
There was a problem hiding this comment. We prefer to fix it in future because it is not the vital problem for milestones |
||
|
|
||
| @POST("repos/{owner}/{repo}/milestones") | ||
| Call<Milestone> createMilestone ( | ||
| @Path("owner") String owner, | ||
| @Path("repo") String repo, | ||
| @Body Milestone milestone); | ||
|
|
||
| @PATCH("repos/{owner}/{repo}/milestones/{number}") | ||
| Call<Milestone> editMilestone ( | ||
| @Path("owner") String owner, | ||
| @Path("repo") String repo, | ||
| @Path("number") long number, | ||
| @Body Milestone milestone); | ||
|
|
||
| @DELETE("repos/{owner}/{repo}/milestones/{number}") | ||
| Call<Milestone> deleteMilestone( | ||
| @Path("owner") String owner, | ||
| @Path("repo") String repo, | ||
| @Path("number") long number); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need a custom adapter for milestones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To allow setting null due_date for milestone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you achieve the same result by modifying the current
DateAdapter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, default adapter for milestones just ignores null properties.
So there is no other way to send patch request with due_on = null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean changing the behavior of https://github.com/jonan/ForkHub/blob/master/app/src/main/java/com/github/mobile/api/DateAdapter.java which is already being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set due_on = null, then DateAdapter is not being called by Milestone adapter because it skips null properties.
Yes, we can achieve it only with DateAdapter, if use some date as null. For example, DateAdapter will replace 01/01/1990 to null. But I am not sure, that it is a better alternative.