fix(session): Add UnexpectedError(CmdError) variant

jonhoo · Oct 19, 2024 · 1085553 · 1085553
1 parent 29bbfa7
commit 1085553
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/error.rs b/src/error.rs
@@ -24,6 +24,8 @@ pub enum NewSessionError {
     NotW3C(serde_json::Value),
     /// The WebDriver server refused to create a new session.
     SessionNotCreated(WebDriver),
+    /// An unexpected error occurred.
+    UnexpectedError(CmdError),
 }
 
 impl Error for NewSessionError {
@@ -35,6 +37,7 @@ impl Error for NewSessionError {
             NewSessionError::Lost(..) => "webdriver server disconnected",
             NewSessionError::NotW3C(..) => "webdriver server gave non-conformant response",
             NewSessionError::SessionNotCreated(..) => "webdriver did not create session",
+            NewSessionError::UnexpectedError(..) => "unexpected webdriver error",
         }
     }
 
@@ -46,6 +49,7 @@ impl Error for NewSessionError {
             NewSessionError::Lost(ref e) => Some(e),
             NewSessionError::NotW3C(..) => None,
             NewSessionError::SessionNotCreated(ref e) => Some(e),
+            NewSessionError::UnexpectedError(ref e) => Some(e),
         }
     }
 }
@@ -61,6 +65,7 @@ impl fmt::Display for NewSessionError {
             NewSessionError::Lost(ref e) => write!(f, "{}", e),
             NewSessionError::NotW3C(ref e) => write!(f, "{:?}", e),
             NewSessionError::SessionNotCreated(ref e) => write!(f, "{}", e),
+            NewSessionError::UnexpectedError(ref e) => write!(f, "{}", e),
         }
     }
 }

diff --git a/src/session.rs b/src/session.rs
@@ -601,9 +601,7 @@ where
                 serde_json::to_value(e)
                     .expect("error::WebDriver should always be serializeable to JSON"),
             )),
-            Err(e) => {
-                panic!("unexpected webdriver error; {}", e);
-            }
+            Err(e) => Err(error::NewSessionError::UnexpectedError(e)),
         }
     }