Initial support for Snell Kahuna K360 Tally #589
Conversation
As yet untested with a real device
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there peternewman 👋
Thank you for opening your first PR for the Tally Arbiter project!
We will review it soon!
TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.
| this.last_heartbeat = Date.now(); | ||
| this.heartbeat_interval = setInterval(() => { | ||
| if (Date.now() - this.last_heartbeat > 5000) { | ||
| clearInterval(this.heartbeat_interval); | ||
| logger(`Source: ${source.name} Snell K360 connection heartbeat timed out`, 'error'); | ||
| // this.client.end(); | ||
| // this.client.destroy(); | ||
| // this.connected.next(false); | ||
| } | ||
| }, 1000); |
There was a problem hiding this comment.
I copied this from the AnalogWayLivecore but I see there's also some more central/higher level stuff done too so maybe this isn't required...
|
Been a bit and I've got a bit of time so I can finally check in on this project. Any luck with getting things to work? |
Hi @JTF4 , I assume you're asking in terms of getting it merged, rather than as a potential user of this PR? I've got sidetracked with other bits, so haven't given this much work from my end and still haven't had a chance to test with real hardware yet. Replaying dummy data from a capture looks promising though. This was my main blocker still, that it wouldn't match multiple instances of the packet within one chunk of data, which feels like it ought to be possible with that parser, and probably solved elsewhere in the codebase already?:
|
|
Ahhhh. Where were you parsing that data in your code? |
1 similar comment
|
Ahhhh. Where were you parsing that data in your code? |
|
These bits: I was intending to try it standalone in some simpler code, to try and make sense of what's going on but haven't had a chance yet. |
|
@peternewman did you ever get any further on this? |
As yet untested with a real device, just lots of data dumps.
See also lots of exploration in https://github.com/peternewman/kahuna-tally/
At the moment if it gets two packets of data in one IP packet (e.g. when you make a cut), it only parses the first one. I've not been able to get packet to work in a for/while loop yet...