Add type assertion and expose component #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tobias Grasse <tg@glancr.de>
Allows to test if a given MockFieldElement instance has the given type. Signed-off-by: Tobias Grasse <tg@glancr.de>
Allows developers to run arbitrary assertions against the component or field. Signed-off-by: Tobias Grasse <tg@glancr.de>
|
Hey @tobias-grasse As a head-up this package was marked as abandoned on packagist recently and has been replaced with a new fork (with @joshgaber's blessing) You can find it here: Packagist and GitHub Feel free to submit your PR over there 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @joshgaber, thanks for this handy helper package. I came across the use-case to assert that the defined field has the given Nova field type. Useful e.g. to assert that an E-mail is rendered with the dedicated
Laravel\Nova\Fields\Emailcomponent instead of a genericTextcomponent.I've added tests for the new method, as well as an
InvalidFieldTypeExceptionto have a nicer error message if the assertion receives an invalid class-string.I also think that publicly exposing
MockComponent::$componentmight come in handy for cases where we want to perform custom assertions on the actual component rather than the MockComponent. If access is restricted for a reason, I can drop those from the PR.