Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Upgrade, PHPUnit 11.x, CI Matrix and PHPUnit Upgrades #64

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

JamesFreeman
Copy link

@JamesFreeman JamesFreeman commented Apr 12, 2024

Hi @joshgaber,

Here's a PR for the Laravel 11.x migration, I've spent some time upgrading the CI.yml to now test against the different PHP versions and Laravel versions.

It's worth noting the tests were failing against main, so I've pulled in #59's PR (👏 - great work @kichetof).

I've also migrated the phpunit.xml to the new format and also allow for PHPUnit 11.

I had a couple of issues, with compatibility with Nova 4, so I've migrated the signature of withOrdering in src/Lenses/MockLensRequest.php. I've also disabled testItSucceedsOnPushResponse due to the fact it was deprecated by Nova now anyway because of these changes it might be worth doing this as a Major jump because of the breaking changes.

New Project secret required

As per the new Nova composer format, you'll need to add a new project secret for ${{ secrets.NOVA_4_EMAIL }}

Let me know if you have any questions or need any more changes.

@kichetof
Copy link

Hi @JamesFreeman !
This PR is perfect! Thanks! With it, at least 2 issues will be behind us and L11 compatible!
Hopefully @joshgaber could take the time to merge it!

@nw-mjl
Copy link

nw-mjl commented Apr 25, 2024

@JamesFreeman Thanks for doing this. For now I have forked the project, but would prefer to just have this one updated.

@JamesFreeman
Copy link
Author

@JamesFreeman Thanks for doing this. For now I have forked the project, but would prefer to just have this one updated.

No problems, I'm in the same boat. I've published this PR if you want to point to my branch.

https://packagist.org/packages/jamesfreeman/novaunit

@JamesFreeman
Copy link
Author

Any updates on this @joshgaber

@VGirol
Copy link

VGirol commented Jul 15, 2024

Any updates on this @joshgaber ?

@karahan
Copy link

karahan commented Jul 25, 2024

@joshgaber any update?

@robertmarney
Copy link
Collaborator

Hey everyone,

As a head-up this package was marked as abandoned on packagist recently and has been replaced with a new fork (with @joshgaber's blessing)

You can find it here: Packagist and GitHub

The latest release provides support for Laravel 11 and latest versions of Nova.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants