update the report viewer to new chart library #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebinside
reviewed
Aug 30, 2023
…t-dependency # Conflicts: # report-viewer/src/components/ClusterRadarChart.vue # report-viewer/src/components/DistributionDiagram.vue
|
[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!
|
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!
|
sebinside
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vue wrapper of chart.js which we currently use (vue-chart-3) is no longer maintained and runs on an over two year old version of chart js (version 3.1.0)
To update chartjs to version 4 and also have a maintained library with all new features this PR proposes the change to vue-chartjs. This library also provides better type safety on the options and input data.
All components using charts were updated to the new library