Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert message for when tracks are added to the queue #491

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Add alert message for when tracks are added to the queue #491

merged 1 commit into from
Jul 4, 2024

Conversation

jholdnak
Copy link
Contributor

@jholdnak jholdnak commented Jul 4, 2024

This adds the ability to tell the user that the song of their choice was added to the queue. Feel free to leave me some feedback as this is my first time programming in Rust, and making an open-source contribution.

Copy link
Collaborator

@jacksongoode jacksongoode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for contributing - and especially as it's your first time contributing to an OSS project!

@jacksongoode jacksongoode merged commit f876f6d into jpochyla:master Jul 4, 2024
5 checks passed
@jacksongoode
Copy link
Collaborator

jacksongoode commented Jul 6, 2024

@jholdnak If you want an even trickier challenge, you'll find that some of the alert messages don't disappear when added in succession. I think there's some issue with the debounce time. Each notification needs a timer that will cause it to vanish after it appears. :) I'd be glad to help you with this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants