Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI cleanup for save track icon #498

Merged
merged 6 commits into from
Aug 4, 2024
Merged

UI cleanup for save track icon #498

merged 6 commits into from
Aug 4, 2024

Conversation

jacksongoode
Copy link
Collaborator

@jacksongoode jacksongoode commented Jul 11, 2024

This PR:

  • Fix some minor string capitalization consistency issues
  • Switches the heart to an add icon (consistent with Spotify)
  • Adds the icon to the row below the duration (to save save horizontal space and prevent reflow when tracks load)

Here's what it would look like:

image image

However, this introduces an issue where clicking on the save icon actually triggers the parents play action - so that would need to be fixed.

@jacksongoode jacksongoode force-pushed the jackson/cleanup branch 2 times, most recently from 7aa16ad to c63c452 Compare July 12, 2024 01:57
@SO9010
Copy link
Contributor

SO9010 commented Jul 24, 2024

However, this introduces an issue where clicking on the save icon actually triggers the parents play action - so that would need to be fixed.

Isn't this the same issue as #457 so not newly introduced?

@jacksongoode
Copy link
Collaborator Author

Yeah actually I made that issue thinking it was the same behavior with the standard UI but the regular UI doesn't put the saved icon on top of the clickable track widget - it adds it to the side.

Currently there are two issues with this PR:

  • Preventing the tracking from playing on saved click
  • Extended track and album titles from pushing the icons out of bounds (this happens on main)

@SO9010
Copy link
Contributor

SO9010 commented Aug 4, 2024

Just a thought but in the ui clean-up branch we could also include some extra icons for visulizing some keyboard bindings, also we should say what they are in the settings to make people aware to how to use them. For example for the search in playlist I think we could have a little icon. We could also have a temporary refresh button introduced.

This would also help with #206

image

@jacksongoode
Copy link
Collaborator Author

I like that idea, I've tried my best to figure out how overlapping triggers in druid can be prevented but I have no idea. I think this can be a PR replacing the heart with the plus. What do you think?

@SO9010
Copy link
Contributor

SO9010 commented Aug 4, 2024

Yeah that sounds good!! I like the fact that the save button will stay larger.

@jacksongoode jacksongoode merged commit a492c33 into master Aug 4, 2024
4 of 5 checks passed
@jacksongoode jacksongoode deleted the jackson/cleanup branch August 4, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants