-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist view update #537
Artist view update #537
Conversation
This is cool and a feature I've been wanting for a while. If we can get the biographies from Spotify, we should just put it at the top of the artist page like you have it. If there's also an image, that would be nice to have as you have in the example. I do think that we could probably keep the monthly listeners and followers underneath the bio and then restrict the bio length to four lines. And perhaps maybe we can add the ability to click on the biography such that it will pop up and present the more expansive metadata and full biography of the artist like we would with the credits view. Since some of these biographies I know are very long. |
This looks great! Thank you! I had the same issue with wrapping the bio text. Do you think we should make the artist image a bit bigger? It seems too small to me right now. I originally set it to match the size of the album cover, but since the artist image is more important, maybe it should be larger. If we don’t adjust the cover image, we could try placing the stats below it. Otherwise, the space between the cover and the bio might look a bit unbalanced. |
I think we could make it bigger a bit. And yeah I ultimately think the stats should be below it in a row perhaps? |
@jacksongoode I found the issue to all our wrapping worries!!! For some reason druid doesn't wrap raw labels! |
@jacksongoode, annoyingly, this hasn't fixed it for the tracks widget! I was very hopeful! |
@jacksongoode, This looks almost ready to be merged now; it just requires your final checks! |
I was having a look at this this weekend and I think it would be really nice if we could structure the artist view such that there are three columns when the window is wide and only two when the window is narrow. We can put the artist stats under the bio when the window is more narrow. But I think having a breakpoint that allows a three column view where the stats are on the far right side when it's most wide would allow the bio to look a little bit more readable at a narrow width. @SO9010 What do you think about this? Right now it just looks a touch messy to me at full width. |
Yeah sounds good I'll work on it asap! |
I made a shot at it, but it would be nice to have it transition at the same breakpoint that the player widget is changing. |
Ok I'll do this! |
All looks good! Thanks @SO9010 ! |
This is a start at #268
This is using the Spotify API. You can right-click to get the social links, the random number of followers, monthly listeners, and world rank (usually 0 as they are too large a number away)!
The main thing that needs to be done is formatting (get the biography wrapped and adequately limited), and then perhaps we could have a text formatting adding in the monthly listeners and followers? @jacksongoode, how should you link these and present them?