Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solarized theme #174

Merged
merged 3 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: ggthemes
Version: 5.1.0
Version: 5.1.0.9000
Title: Extra Themes, Scales and Geoms for 'ggplot2'
Authors@R: c(person("Jeffrey B.", "Arnold", role = c("aut", "cre"),
email = "jeffrey.arnold@gmail.com",
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# ggthemes (development version)

- Updated `theme_solarized` to fix `key.background` color.

# ggthemes 5.1.0

- Updated `scale_color_gdocs` and `gdocs_pal` to use current colors. Palette extended from 10 to 24 colors.
Expand Down
5 changes: 1 addition & 4 deletions R/solarized.R
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,7 @@ theme_solarized <- function(base_size = 12, base_family = "", light = TRUE) {
linetype = 1
),
legend.background = element_rect(fill = NULL, color = NA),
legend.key = element_rect(
fill = NULL,
colour = NULL, linetype = 0
),
legend.key = element_blank(),
panel.background = element_rect(
fill = rebase["rebase03"],
colour = rebase["rebase01"]
Expand Down