Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and Update Tested Versions #239

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
memcached:
image: memcached
ports:
- 11211:11211
- 57823:11211
Copy link
Contributor Author

@Andrew-Chen-Wang Andrew-Chen-Wang Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentionally set to 11211 so that the connection would fail by setting a LOCATION of a random free client port. Please revert the last two commits.

Copy link

@mahyard mahyard Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad! all of yesterday I was doing nothing. I thought... never mind. I will revert it right now.

strategy:
fail-fast: false
matrix:
Expand Down