Possible approach to support schemas nested in non-schema docs #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
commented
Dec 27, 2022
| @@ -55,11 +55,15 @@ public void Evaluate(EvaluationContext context) | |||
| if (scopeRoot == null) | |||
| throw new Exception("This shouldn't happen"); | |||
|
|
|||
| if (scopeRoot.RecursiveAnchor == null) continue; | |||
| if (scopeRoot is not JsonSchema schemaRoot) | |||
| throw new Exception("Does OpenAPI use anchors?"); | |||
There was a problem hiding this comment.
Not sure this is entire relevant here since $recursiveRef is exclusively 2019-09.
|
Maggie and I discussed this today. This looks like an approach that would work for us. We will do some more investigation on our side. |
…penapidoc to test
gregsdennis
force-pushed
the
schema/reference-resolution
branch
from
0248599
to
5dd8f86
Compare
|
I think this is going to be a good addition to the library, so I'm going to go ahead and incorporate it into the beta. |
github-actions
bot
added
pkg:schema-data
pkg:schema-openapi
pkg:schema-unique-keys
labels
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #355
Relates to microsoft/OpenAPI.NET#795
There are some comments in the code, but basically the
SchemaRegistrynow tracksIBaseDocuments instead of justJsonSchemas. TheOpenApiDoc(or whatever it'll be called) will need to:IBaseDocumentIt's a bit hacked together right now, but it works.