Fix issues with tox targets lint & docs #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `lint` target: this ignores the vendored in `charmtools/diff_match_patch.py` file which uses completely non-standard indenting (2 spaces). It also fixes various issues around bare exceptions, indendation and equality tests on types. * `docs` target: this fixes the custom /docs/_extensions/automembersummary.py extension to be able to use a more recent version of sphinx. This fixes a long-standing broken sphinx docs generation issue.
javacruft
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linttarget: this ignores the vendored incharmtools/diff_match_patch.pyfile which uses completelynon-standard indenting (2 spaces). It also fixes various issues around
bare exceptions, indendation and equality tests on types.
docstarget: this fixes the custom/docs/_extensions/automembersummary.py extension to be able to use a
more recent version of sphinx. This fixes a long-standing broken
sphinx docs generation issue.
Description of change
Checklist
make test?