Python 3.12 support #672
Merged
Python 3.12 support #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu 24.04 carries python 3.12, hence the importance to gate on it.
inspect.getargspec() is deprecated and finally removed in Python 3.11[0], the replacement is to use inspect.getfullargspec(), see [1] [0] python/cpython@d89fb9a [1] https://docs.python.org/3.10/library/inspect.html#inspect.getargspec
The former has been removed in newer versions of python.
Replace '-e {toxinidir}' with 'package = editable', this allows
adding the source code early in the process and avoid packages listed
in the deps section to pull in charm-tools from pypi.
The package charm-templates-openstack depends on charm-tools, including it in the list of `deps` in tox.ini creates a circular dependency, since the `deps` list is processed before installing the local package.
freyes
force-pushed
the
py312-support
branch
2 times, most recently
from
48296f7
to
0a20c42
Compare
|
evidence that the built charm on ubuntu@24.04 built the right wheels |
ajkavanagh
approved these changes
Apr 19, 2024
|
is this incorporated in a new charm snap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python 3.12, summary of changes:
inspect.getargspec()withinspect.getfullargspec()self.assertEquals()withself.assertEqual()Checklist
make test?