Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce method filter support in the ConsoleLauncher #3169

Merged

Conversation

yhkuo41
Copy link
Contributor

@yhkuo41 yhkuo41 commented Feb 25, 2023

Issue: #3107

Overview

Solves #3107.

After referring to other Filters (such as TagFilter), I am not sure if I should implement both IncludeMethodFilter and ExcludeMethodFilter, please let me know if I should remove IncludeMethodFilter.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp
Copy link
Member

After referring to other Filters (such as TagFilter), I am not sure if I should implement both IncludeMethodFilter and ExcludeMethodFilter, please let me know if I should remove IncludeMethodFilter.

We originally thought we didn't need an include filter because there's already a way to select particular methods. However, the latter does not allow specifying wildcards so there might be some use cases where it would be beneficial.

Team decision: Add both --include-methodname and --exclude-methodname.

@yhkuo41
Copy link
Contributor Author

yhkuo41 commented Mar 7, 2023

@marcphilipp Thanks for the feedback, I've added the cli options.

@yhkuo41 yhkuo41 force-pushed the origin/issues/3107-method-filters branch 4 times, most recently from f03f888 to 2f26377 Compare April 19, 2023 04:11
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I caused a lot of merge conflicts by introducing subcommands in the ConsoleLauncher recently. The new options should now be added to TestDiscoveryOptionsMixin.FilterOptions instead.

@Sakieye Do you have time to rework the PR?

@yhkuo41 yhkuo41 force-pushed the origin/issues/3107-method-filters branch from 22210ca to 2b90fd0 Compare May 21, 2023 14:44
@yhkuo41 yhkuo41 requested a review from marcphilipp May 21, 2023 15:00
@yhkuo41 yhkuo41 force-pushed the origin/issues/3107-method-filters branch from 2b90fd0 to bfc798b Compare May 28, 2023 13:29
@yhkuo41
Copy link
Contributor Author

yhkuo41 commented Jun 8, 2023

I'm afraid I caused a lot of merge conflicts by introducing subcommands in the ConsoleLauncher recently. The new options should now be added to TestDiscoveryOptionsMixin.FilterOptions instead.

@Sakieye Do you have time to rework the PR?

@marcphilipp I've updated my PR, please help review again

@yhkuo41 yhkuo41 force-pushed the origin/issues/3107-method-filters branch from 3fdbe6d to ba42ab9 Compare July 26, 2023 01:04
@yhkuo41
Copy link
Contributor Author

yhkuo41 commented Aug 20, 2024

@marcphilipp Do you still need this feature? If so, I can update it sometime soon.

@marcphilipp
Copy link
Member

@marcphilipp Do you still need this feature? If so, I can update it sometime soon.

Yes, that'd be great if you're still interested! 👍

@yhkuo41 yhkuo41 force-pushed the origin/issues/3107-method-filters branch from ba42ab9 to fbfcb36 Compare September 23, 2024 09:56
@yhkuo41
Copy link
Contributor Author

yhkuo41 commented Sep 23, 2024

@marcphilipp I updated my PR again, please help review

@marcphilipp marcphilipp merged commit 0de9d10 into junit-team:main Oct 16, 2024
15 checks passed
@marcphilipp
Copy link
Member

@yhkuo41 Thank you for your contribution! 👍

@yhkuo41
Copy link
Contributor Author

yhkuo41 commented Oct 16, 2024

My pleasure 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce exclude-method filter to complement select-method selector
3 participants