-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace opt-in annotation with extension method #4062
Merged
marcphilipp
merged 5 commits into
main
from
marc/replace-annotation-with-extension-method
Oct 11, 2024
Merged
Replace opt-in annotation with extension method #4062
marcphilipp
merged 5 commits into
main
from
marc/replace-annotation-with-extension-method
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids being able to opt out should the default be changed to test-scoped.
marcphilipp
force-pushed
the
marc/replace-annotation-with-extension-method
branch
from
October 9, 2024 08:13
3e49904
to
ba6cd95
Compare
marcphilipp
commented
Oct 9, 2024
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
marcphilipp
commented
Oct 9, 2024
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
marcphilipp
force-pushed
the
marc/replace-annotation-with-extension-method
branch
from
October 9, 2024 08:41
ba6cd95
to
5acbdb6
Compare
This was referenced Oct 9, 2024
@JojOatXGME I'd appreciate it if you could take a look! |
marcphilipp
force-pushed
the
marc/replace-annotation-with-extension-method
branch
from
October 9, 2024 08:58
5acbdb6
to
bef4874
Compare
This enforces that only potentially affected extensions can override the method determining the extension context scope during test class instance construction.
marcphilipp
force-pushed
the
marc/replace-annotation-with-extension-method
branch
from
October 9, 2024 09:00
bef4874
to
bbafe10
Compare
JojOatXGME
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I still kept a few comments to communicate what I was thinking while reading your PR.
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
6 tasks
marcphilipp
commented
Oct 11, 2024
...ava/org/junit/jupiter/api/extension/TestClassInstanceConstructionParticipatingExtension.java
Outdated
Show resolved
Hide resolved
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations