Use new extension context scope in core extensions #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Base automatically changed from
marc/replace-annotation-with-extension-method
to
main
October 11, 2024 13:58
An error occurred while trying to automatically change base from
marc/replace-annotation-with-extension-method
to
main
October 11, 2024 13:58
marcphilipp
force-pushed
the
marc/core-extensions-scope-adoption
branch
from
108047c
to
2fd2439
Compare
This extension is not affected by the change in behavior since annotating test class constructors with `@Timeout` is not supported.
This extension is not affected by the change in behavior since it did not use the supplied `ExtensionContext`.
This extension is not affected by the change in behavior since it does not support resolving parameters for test class constructors.
When injecting `TestReporter` into test class constructors the published report entries are now associated with the test method rather than the test class unless the test instance lifecycle is set to `PER_CLASS` (in which case they will continue to be associated with the test class).
When injecting `TestInfo` into test class constructors it now contains data of the test method the test class instance is being created for unless the test instance lifecycle is set to `PER_CLASS` (in which case it continues to contain the data of the test class).
marcphilipp
force-pushed
the
marc/core-extensions-scope-adoption
branch
from
2fd2439
to
1e1f92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations