negative range seems to work #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
reviewed
Apr 18, 2024
tests/test_parser.py
Outdated
Comment on lines
531
to
533
| parser.parse("[-1 TO 5]") | ||
| parser.parse("[-10 TO -1]") | ||
| parser.parse("[5 TO -1]") # semantically incorrect but correct from the parser's perspective |
There was a problem hiding this comment.
You should test the resulting tree is that expected, (as we do in other non raising tests).
|
Also you have to make your code pass quality checks. |
|
Hi Alex, sorry for wasting your time, I will. This is still a work in progress - it seems to work but introduces one reduce/reduce conflict (solved favorably for us but still not pretty). I will have a look if the grammar could be rewritten to circumvent this, but it will unfortunately be a much bigger change than this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.