Skip to content

Fix Style/DirectiveScope offense failing the RuboCop build #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakinj merged 1 commit into from
Sep 2, 2026
+2 −2
Merged

Fix Style/DirectiveScope offense failing the RuboCop build #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
**Fixes and enhancements:**

- Fix rejection of unknown algorithms from JWKs for RFC compliance and pquip [#728](https://github.com/jwt/ruby-jwt/pull/728)
- Fix the `Style/DirectiveScope` RuboCop offense failing the build [#752](https://github.com/jwt/ruby-jwt/pull/752)

## [v3.2.0](https://github.com/jwt/ruby-jwt/tree/v3.2.0) (2026-05-13)

Expand Down
3 changes: 1 addition & 2 deletions lib/jwt/jwa/hmac.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def validate_key_length!(key)
end

# Copy of https://github.com/rails/rails/blob/v7.0.3.1/activesupport/lib/active_support/security_utils.rb
# rubocop:disable Naming/MethodParameterName, Style/StringLiterals, Style/NumericPredicate
# rubocop:disable-next Naming/MethodParameterName, Style/StringLiterals, Style/NumericPredicate
module SecurityUtils
# Constant time string comparison, for fixed length strings.
#
Expand Down Expand Up @@ -94,7 +94,6 @@ def secure_compare(a, b)
end
module_function :secure_compare
end
# rubocop:enable Naming/MethodParameterName, Style/StringLiterals, Style/NumericPredicate
end
end
end
Loading