Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown socket gracefully. Simplify server cleanup. #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eryx67
Copy link

@eryx67 eryx67 commented Feb 29, 2016

This patch add two things:

  • shutdown socket before closing
  • change custom forkFinally with the same function from SlaveThread to
    simplify server cleanup on shutdown. Without it user need to develop a custom solution
    for killing incoming connections or they will wait for client disconnections.

@k0001
Copy link
Owner

k0001 commented Mar 1, 2016

Thank you @eryx67. The shutdown change is good, we should add it. Let me think about slave-thread a bit more though: I think it is a good idea in principle, but I am a bit hesitant about adding dependencies to this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants