Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to refer to --kafka-conf instead of --config #173

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Update README to refer to --kafka-conf instead of --config #173

merged 1 commit into from
Sep 9, 2024

Conversation

tmancill
Copy link
Contributor

@tmancill tmancill commented Sep 9, 2024

Hi, thanks for sharing kommitted.

I noticed that the README and the --help output refer to --config, but that option is not (or no longer) supported and results in this error message:

error: unexpected argument '--config' found

This PR updates references to --config to be --kafka-conf.

detro
detro approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still things to improve on this. Because of the new job, I have had a PR parked for months now. It needs a way to deal better with "Consumer Group changes".

But I'm glad if an expert of your caliber is kicking the tires Tony.

@detro detro merged commit b9d46dc into kafkesc:main Sep 9, 2024
1 check passed
@tmancill tmancill deleted the kafka-conf-readme branch September 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detro detro detro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancill @detro