Adding metrics to the consumer_groups module
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detro
added a commit
that referenced
this pull request
Nov 8, 2023
…ups` module These were added in #91. Nothing changes: just the code to wire it up is a bit simpler/cleaner now.
detro
added a commit
that referenced
this pull request
Nov 8, 2023
* Using utility macros to create and register metrics for `consumer_groups` module These were added in #91. Nothing changes: just the code to wire it up is a bit simpler/cleaner now. * Adding metrics to `partition_offsets` emtitter, and documenting them * `kmtd_partition_offsets_emitter_fetch_time_milliseconds` * `kmtd__partition_offsets_emitter_channel_capacity` * Deps upgrade * Cleaning up const and var names used to create the new metrics Nothing major: some just renaming that I couldn't leave inconsistent. * New metric `kmtd_partition_offsets_register_usage` to track how many offsets we are tracking internally for each topic-partition * Documenting the new metric `kmtd_partition_offsets_register_usage` * No need to prefix each metric handled by the `prometheus` package with `{NAMESPACE}` This is set already on the registry, so it gets added automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
Closes #53