Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ember 3.16+ support #112

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

matthewhartstonge
Copy link

Howdy!

We've got a rather large app that makes use of this addon and am trying to punch up to Ember@5. (we have a lot of HTML+CSS to untangle sitting in sticky elements)

This is the start of where I'm at to get us compiling due to relying on ember-in-viewport. Thought I would punch up what I've done so far.

Viewport doesn't seem to be firing 'well' so I've had to do a dirty and rely on debouncing on scroll, but that still doesn't seem to fix the boxes sticking to the bottom in the dummy app.

I'm a backend dev attempting to upgrade our frontend app, so apologies if I'm committing heinous sins.

1..183
# tests 183
# pass  171
# skip  0
# todo  0
# fail  12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant