Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy!
We've got a rather large app that makes use of this addon and am trying to punch up to Ember@5. (we have a lot of HTML+CSS to untangle sitting in sticky elements)
This is the start of where I'm at to get us compiling due to relying on
ember-in-viewport
. Thought I would punch up what I've done so far.Viewport doesn't seem to be firing 'well' so I've had to do a dirty and rely on debouncing on scroll, but that still doesn't seem to fix the boxes sticking to the bottom in the dummy app.
I'm a backend dev attempting to upgrade our frontend app, so apologies if I'm committing heinous sins.