Merge pull request #90 from kaliiiiiiiiii/dev

Version == 2.2.9

.github/ISSUE_TEMPLATE/bug_report.md

@@ -24,9 +24,10 @@ A clear and concise description of what you expected to happen.
 **Environment (please complete the following information):**
  - OS: [e.g. Windows, Google-Colab ]
 - OS-Version [e.g. 10]
-- Browser [e.g. Google-Chrome, Chromium]
+- Browser [e.g. `Google-Chrome, 115.0.5790.166 (Official Build) (64-Bit) `]
  - Selenium-Profiles Version [e.g. 2.2.5.1]
  - Selenium Version [e.g. 4.11.1]
+ - Python versin [e.g. 3.7.9]
 
 **Additional context**
 Add any other context about the problem here.

README.md

@@ -121,7 +121,6 @@ profile = \
 ### selenium-driverless
 warning: 
 - this package is experimental and might include bugs, please report them at [bug-reports](https://github.com/kaliiiiiiiiii/Selenium-Driverless/issues)
-- only for python >=3.8
 ```python
 from selenium_profiles.webdriver import Chrome
 from selenium_profiles.profiles import profiles

requirements.txt

@@ -1,9 +1,15 @@
-selenium_profiles>=2.2.5.5
-requests==2.31.0
-selenium==4.8.3 # 4.1.0 for touch_actions
-setuptools==67.6.0
-undetected-chromedriver==3.4.6
-trio
-pillow
-selenium-interceptor>=1.0.2
-selenium-wire
+selenium
+requests
+selenium-interceptor
+undetected-chromedriver
+selenium-wire
+webdriver-manager
+selenium-injector>=2.3
+
+# google-colab
+# PyVirtualDisplay
+# google-colab-shell
+
+# dev
+setuptools
+twine

setup.py

@@ -4,12 +4,7 @@
 
 requirements = ['selenium', 'requests', 'selenium-interceptor',
                 "undetected-chromedriver", "selenium-wire", "webdriver-manager",
-                "selenium-injector>=2.3"]
-
-py_version = sys.version_info
-if py_version.major >= 3 and py_version.minor >= 8:
-    # requires python >= 3.8
-    requirements.append("selenium-driverless>=1.2.2")
+                "selenium-injector>=2.3","selenium-driverless>=1.2.2"]
 
 if 'google.colab' in sys.modules: # we're on google-colab
     requirements.extend(['PyVirtualDisplay', "google-colab-shell"])

src/selenium_profiles/__init__.py

@@ -1 +1 @@
-__version__ = "2.2.8"
+__version__ = "2.2.9"

src/selenium_profiles/scripts/driver_utils.py

@@ -1,7 +1,7 @@
 class requests:
     def __init__(self, driver):
         self.driver = driver
-        self.methods = ["GET","HEAD" "POST", "PUT", "DELETE","OPTIONS"] # TRACE, CONNECT exluded here
+        self.methods = ["GET","HEAD", "POST", "PUT", "DELETE","OPTIONS"] # TRACE, CONNECT exluded here
         self.supported_credentials = ["omit", "same-origin", "include"]
         self.modes = ["cors", "no-cors", "same-origin"]
         self.cache_values = ["default", "no-store", "reload", "no-cache", "force-cache", "only-if-cached"]

src/selenium_profiles/webdriver.py

@@ -108,7 +108,7 @@ def __init__(self, profile: dict = None, chrome_binary: str = None, executable_p
                                           safe_duplicates=safe_duplicates)
 
         # chrome executable path
-        if not chrome_binary:
+        if chrome_binary:
             options_manager.Options.binary_location = chrome_binary
 
         if (uc_webdriver.Chrome in base_drivers) or (wire_uc_webdriver.Chrome in base_drivers):