-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add PR template. New impl checklist in template and FAQ
- Loading branch information
Showing
2 changed files
with
43 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Pull request requirements: | ||
|
||
- [ ] Commits are well written and well organized. | ||
- [ ] Commits for a specific implementation should be prefixed with | ||
the implementation name. | ||
- [ ] Github Actions CI passes all checks (including self-host) | ||
|
||
Additional requirements if your are adding a new implementation (see | ||
[FAQ](docs/FAQ.md#add_implementation) for details): | ||
|
||
- [ ] Follow incremental structure (no common eval code) | ||
- [ ] Add `impls/<IMPL>/Dockerfile` | ||
- [ ] Add `impls/<IMPL>/Makefile` | ||
- [ ] Add to `IMPLS.yml` | ||
- [ ] Add to `Makefile.impls` | ||
- [ ] Update `README.md` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters