step 7: Test `([~a]). #398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unquote inside a vector inside a list inside quasiquote breaks some implementations, which return ([(unquote a)]) for the above instead of ((8)) (when a is defined to be 8). Bug spotted by Nicolas Boulenguez <nicolas.boulenguez@free.fr> in kanaka@2dfe777
|
I have prepared a bunch of regression tests, but we should agree on the intended behaviour before adding tests. See the discussion at the end of #103. |
|
This change is now part of PR #401. |
|
Now that PR #401 is merged, I suggest to close this one. |
|
Agreed. Closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been following #384 very carefully, but I think while @asarhaddon added a workaround in 2dfe777 for guile's problems with expressions like
`([~a]), there wasn't any talk of testing for or fixing the bug. So here's a test for it.I think the test is correct based on the guide's specification of
quasiquote, and at least the perl and python implementations agree with me.Implementations that would need to be fixed to deploy this test:
(plpgsql failure is unrelated)