Fix error of saving the whole MalSymbol object as a key on the Env #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta MAP object Instead of using a Map use a pure object with key values and use the MalSymbol.v as a key (the value) instead of the whole object
|
Closing this as I fixed the issue by adding a Map() polyfill |
|
Sorry for the slow reply. My PhD dissertation has been keeping me busy lately. Are you sure you don't want to merge this so that other people get the fix automatically? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a Map use a pure object with key values and use the MalSymbol.v as a key (the value) instead of the whole object
This PR fixes a bug reported here: #404