Update elm implementation, fix keywords and metadata, merge eval #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most changes are variable renamings because elm does not allow masking a visible name anymore. Deal with changes in the standard library, especially in the Parser interface. Source files must now start with a capital letter. Dockerfile: remove unneeded dependencies, install nodejs from debs. Remove the redundant Maybe from the return value of readstring. Stop embedding the colon in keyword represenation.
|
The tests were passing on my machine, so they will probably also pass in an updated Docker image. |
This was referenced Feb 18, 2022
Remove obsolete comment. Fix a typo and avoid an unneeded function mapping.
It was necessary to rename some ambiguous variables. Some more names could probably be changed in order to reduce the diff with kanaka#450 (my names were choosen in order to reduce the diff with master...) Peek ideas from kanaka#450: - sort imports - skip a line between '->' or before 'else' - no indentation after 'in' - fix indentation when it was only intended to reduce diff - remove some unneeded parenthesis and - if .. return True else False -> ...
Various trivial changes reducing the diff to kanaka#450. Dockerfile: npm already depends on nodejs Core.elm: change profile of deepEquals instead of uncurrying before each call.
asarhaddon
force-pushed
the
update-elm
branch
from
fa5249f
to
0cc6296
Compare
|
Hello. |
|
Yeah, seems like it's a behavior that started midstream in an Ubuntu release. The trick is this: |
|
Update with fixed the Dockerfile issue and a Makefile bug (probably search/replace issue). Merged these commits from my own branch so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
The first commit updates the elm implementation for 0.19.1. The docker file describes my configuration but should probably be checked on an actual image.
The two following commits fix the last failing optional tests.
The two last commits should be part of #592, but required 0.19.1 for testing.