Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elm implementation, fix keywords and metadata, merge eval #608

Closed
wants to merge 9 commits into from

Conversation

asarhaddon
Copy link
Contributor

Hello.
The first commit updates the elm implementation for 0.19.1. The docker file describes my configuration but should probably be checked on an actual image.
The two following commits fix the last failing optional tests.
The two last commits should be part of #592, but required 0.19.1 for testing.

Most changes are variable renamings because elm does not allow masking
a visible name anymore.

Deal with changes in the standard library, especially in the Parser
interface.

Source files must now start with a capital letter.

Dockerfile: remove unneeded dependencies, install nodejs from debs.

Remove the redundant Maybe from the return value of readstring.

Stop embedding the colon in keyword represenation.
@asarhaddon
Copy link
Contributor Author

The tests were passing on my machine, so they will probably also pass in an updated Docker image.

Remove obsolete comment.

Fix a typo and avoid an unneeded function mapping.
It was necessary to rename some ambiguous variables. Some more names
could probably be changed in order to reduce the diff with kanaka#450 (my
names were choosen in order to reduce the diff with master...)

Peek ideas from kanaka#450:
- sort imports
- skip a line between '->' or before 'else'
- no indentation after 'in'
- fix indentation when it was only intended to reduce diff
- remove some unneeded parenthesis
and
- if .. return True else False -> ...
Various trivial changes reducing the diff to kanaka#450.

Dockerfile: npm already depends on nodejs

Core.elm: change profile of deepEquals instead of uncurrying before
each call.
@asarhaddon
Copy link
Contributor Author

Hello.
For some reason, the installation of the tzdata package interactively asks the geographical area, so the actual tests do not even start. I have no idea how to debug this.

@kanaka
Copy link
Owner

kanaka commented Aug 5, 2024

Yeah, seems like it's a behavior that started midstream in an Ubuntu release. The trick is this:

RUN DEBIAN_FRONTEND=noninteractive apt-get -y ...

@kanaka
Copy link
Owner

kanaka commented Aug 6, 2024

Update with fixed the Dockerfile issue and a Makefile bug (probably search/replace issue). Merged these commits from my own branch so closing this.

@kanaka kanaka closed this Aug 6, 2024
@asarhaddon asarhaddon deleted the update-elm branch August 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants