Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua: merge evalAST and fix remaining tests #664

Merged
merged 12 commits into from
Aug 26, 2024
Merged

Lua: merge evalAST and fix remaining tests #664

merged 12 commits into from
Aug 26, 2024

Conversation

asarhaddon
Copy link
Contributor

No description provided.

kanaka
kanaka requested changes Aug 22, 2024
View reviewed changes
Copy link
Owner

@kanaka kanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great. I think the build failure is just that the lua-5.3 package needs to be lua5.3. You might be aware already but if you have docker on your system you can run make "docker-build^lua" to test the docker image build.

@kanaka kanaka merged commit dab788c into kanaka:master Aug 26, 2024
4 checks passed
@asarhaddon asarhaddon deleted the lua branch August 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanaka kanaka kanaka requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asarhaddon @kanaka