Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mal: implement DBGEVAL without assuming that a: is a valid symbol #673

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

asarhaddon
Copy link
Contributor

This does not seem worth a test, but can currently break the self-hosting.

This does not seem worth a test, but can currently break the
self-hosting.
@kanaka kanaka merged commit 5549585 into kanaka:master Aug 27, 2024
7 checks passed
@asarhaddon
Copy link
Contributor Author

Sorry, I am cleaning the backlog in semi-random order.
A test for a: has been included meanwhile.
Do you want me to downgrade its severity? With this merged, a: is nice but not required for self-hosting.

@asarhaddon asarhaddon deleted the mal branch August 27, 2024 19:40
@kanaka
Copy link
Owner

kanaka commented Aug 27, 2024

I don't have a strong opinion. I do tend to lean towards having optional things be marked optional in the tests. That way implementors don't get hung up if those optional tests are hard to do in their target language. In this case it's probably not going to trip up implementations. Although I could be wrong. When I was implementing bash it had a bunch of these types of things that should have been simple but ended up triggering weird behaviors (like "*, "!", etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants