Addressing issue #64 and issue #98: rewrite existential multi-head rules

karmaresearch · Nov 22, 2022 · cfc7b0d · cfc7b0d
1 parent dd28102
commit cfc7b0d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/src/vlog/common/concepts.cpp b/src/vlog/common/concepts.cpp
@@ -1325,7 +1325,13 @@ void Program::addRule(std::vector<Literal> heads, std::vector<Literal> body,
         rewriteRule(heads, body);
     } else {
         Rule rule(allrules.size(), heads, body, isEGD);
-        addRule(rule);
+        if (heads.size() > 1 && rule.isExistential()) {
+            // Work-around for bug in existential multihead rules, github issue #98 and issue #64.
+            // Easiest fix is to just rewrite these rules.
+            rewriteRule(heads, body);
+        } else {
+            addRule(rule);
+        }
     }
 }
 

diff --git a/src/vlog/forward/seminaiver.cpp b/src/vlog/forward/seminaiver.cpp
@@ -1831,14 +1831,16 @@ void SemiNaiver::printCountAllIDBs(std::string prefix) {
     for (PredId_t i = 0; i < program->getNPredicates(); ++i) {
         if (predicatesTables[i] != NULL) {
             if (program->isPredicateIDB(i)) {
-                size_t count = predicatesTables[i]->getNAllRows();
-                if (count == 0) {
-                    emptyRel++;
-                }
                 std::string predname = program->getPredicateName(i);
-                LOG(DEBUGL) << prefix << "Cardinality of " <<
-                    predname << ": " << count;
-                c += count;
+                if (predname.rfind("__Generated", 0) != 0) {
+                    // Only count original predicates.
+                    size_t count = predicatesTables[i]->getNAllRows();
+                    LOG(DEBUGL) << prefix << "Cardinality of " << predname << ": " << count;
+                    if (count == 0) {
+                        emptyRel++;
+                    }
+                    c += count;
+                }
             }
         }
     }