Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of project instances reporting functionality #103

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

Samweli
Copy link
Collaborator

@Samweli Samweli commented Sep 28, 2024

Fixes #95

Adds ability to generate multiple reports for the selected project instance.

gea_reporting_instances.mp4

Copy link

github-actions bot commented Sep 28, 2024

badge

Plugin zip package for the changes in this PR has been successfully built!.

Download the plugin zip file here https://github.com/kartoza/qgis-gea-plugin/suites/29666788959/artifacts/2060734635

Copy link
Collaborator

@amyburness amyburness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reporting feature looks good I am happy with the workflows and the report layout. Note: one addition the farmer ID labels need a white outline/background @Jeremy-Prior has sent a style for this.

@amyburness
Copy link
Collaborator

@Samweli I have an issue with the creation of the report for the project instance please see this gif.
when I select the layer and select the generate report it says in need a site reference but I souldn't need one for the instance reporting.
issue on report
cc @ketankartoza is this the same issue you have.

@ketankartoza
Copy link
Collaborator

Yes @amyburness

@Samweli
Copy link
Collaborator Author

Samweli commented Oct 1, 2024

@Samweli I have an issue with the creation of the report for the project instance please see this gif.

@amyburness I have pushed a fix, can you download the new zip and check, thanks.

@amyburness
Copy link
Collaborator

@Samweli I have an issue with the creation of the report for the project instance please see this gif.

@amyburness I have pushed a fix, can you download the new zip and check, thanks.

@Samweli I downloaded the zip from the link above and I am having the same issues see screenshot. Am I testing the wrong Zip?

image

…nd fix the issue in creating the report directory
@Samweli
Copy link
Collaborator Author

Samweli commented Oct 2, 2024

@Samweli I downloaded the zip from the link above and I am having the same issues see screenshot. Am I testing the wrong Zip?

No you were not testing a wrong zip. I have made new changes and fix, you can redownload and check again. This time we will have a more information in the log if it fails again. thanks

@Samweli
Copy link
Collaborator Author

Samweli commented Oct 2, 2024

Ping @amyburness

@amyburness
Copy link
Collaborator

@Samweli testing now

@amyburness
Copy link
Collaborator

@Samweli

  1. good
  2. good
  3. the report doesn't generate

image

@amyburness
Copy link
Collaborator

@Samweli

The reporting is working, Notes.

  1. The IncepDate will come with the base data the user uses. We do not need to make this attribute column but I think it is important to track when the user imported the data and worked on it so the current column called IncepDate can we renamed to ImpDate (standing for import date). for the reporting, we must keep the data showing the IncepDate (this ill come with the data)
  2. The polygon labels take some time to load say 1 minute. it works but slowly.
  3. The reports are now generating :) but I ran into some issues:
    a. the generation of the reports stopped at 75% on my first run I am not sure why, I ran it again and all 11 generated no problem (I will test again). the log said this.

image

b. the layout inception date is over two lines and then overlaps with the label below can we make the label font a little smaller so it fits on one line? 

image

@Samweli Samweli merged commit fa77bbf into kartoza:main Oct 15, 2024
5 checks passed
Samweli added a commit that referenced this pull request Oct 15, 2024
Implementation of project instances reporting functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UR 9: Generate an automated report
3 participants