Skip to content

Commit

Permalink
Remove a number of graveyarded --incompatible_* command line options.
Browse files Browse the repository at this point in the history 
RELNOTES[INC]: The following command line options are not supported anymore: --incompatible_disable_cc_configuration_make_variables, --incompatible_disable_cc_toolchain_label_from_crosstool_proto, --incompatible_disable_crosstool_file, --incompatible_disable_depset_in_cc_user_flags, --incompatible_disable_legacy_cpp_toolchain_skylark_api, --incompatible_disable_legacy_cpp_toolchain_skylark_api, incompatible_disable_legacy_flags_cc_toolchain_api, --incompatible_disable_managed_directories, --incompatible_disable_runtimes_filegroups, --incompatible_disable_sysroot_from_configuration, --incompatible_disable_tools_defaults_package, --incompatible_disallow_legacy_javainfo, --incompatible_dont_emit_static_libgcc, --incompatible_enable_legacy_cpp_toolchain_skylark_api, --incompatible_linkopts_in_user_link_flags, --incompatible_provide_cc_toolchain_info_from_cc_toolchain_suite, --incompatible_require_feature_configuration_for_pic .

PiperOrigin-RevId: 568825085
Change-Id: Ib7dd8407fd4e7644c9ccfaea856c7b1a7a7d5bc3
  • Loading branch information
@lberki @copybara-github
lberki authored and copybara-github committed Sep 27, 2023
1 parent e45b8d4 commit 20528af
Showing 1 changed file with 0 additions and 139 deletions.
139 changes: 0 additions & 139 deletions src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,119 +104,6 @@ public static class BuildGraveyardOptions extends OptionsBase {
help = "Deprecated. No-op.")
public boolean skyframePrepareAnalysis;

@Option(
name = "incompatible_disable_crosstool_file",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableCrosstool;

@Option(
name = "incompatible_disable_legacy_crosstool_fields",
oldName = "experimental_disable_legacy_crosstool_fields",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableLegacyCrosstoolFields;

@Option(
name = "incompatible_require_feature_configuration_for_pic",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean requireFeatureConfigurationForPic;

@Option(
name = "incompatible_disable_depset_in_cc_user_flags",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableDepsetInUserFlags;

@Option(
name = "incompatible_dont_emit_static_libgcc",
oldName = "experimental_dont_emit_static_libgcc",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.TOOLCHAIN,
effectTags = {OptionEffectTag.ACTION_COMMAND_LINES, OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableEmittingStaticLibgcc;

@Option(
name = "incompatible_linkopts_in_user_link_flags",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.TOOLCHAIN,
effectTags = {OptionEffectTag.ACTION_COMMAND_LINES, OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean enableLinkoptsInUserLinkFlags;

@Option(
name = "incompatible_disable_runtimes_filegroups",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.TOOLCHAIN,
effectTags = {OptionEffectTag.ACTION_COMMAND_LINES, OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableRuntimesFilegroups;

@Option(
name = "incompatible_disable_tools_defaults_package",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS, OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean incompatibleDisableInMemoryToolsDefaultsPackage;

@Option(
name = "incompatible_disable_sysroot_from_configuration",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableSysrootFromConfiguration;

@Option(
name = "incompatible_provide_cc_toolchain_info_from_cc_toolchain_suite",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean provideCcToolchainInfoFromCcToolchainSuite;

@Option(
name = "incompatible_disable_cc_toolchain_label_from_crosstool_proto",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS, OptionEffectTag.EAGERNESS_TO_EXIT},
metadataTags = {OptionMetadataTag.DEPRECATED, OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "Deprecated no-op.")
public boolean disableCcToolchainFromCrosstool;

@Option(
name = "incompatible_disable_cc_configuration_make_variables",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.UNKNOWN},
metadataTags = {
OptionMetadataTag.INCOMPATIBLE_CHANGE,
OptionMetadataTag.DEPRECATED,
},
help = "Deprecated no-op.")
public boolean disableMakeVariables;

@Option(
name = "incompatible_disable_legacy_flags_cc_toolchain_api",
defaultValue = "true",
Expand All @@ -228,24 +115,6 @@ public static class BuildGraveyardOptions extends OptionsBase {
+ "CROSSTOOL fields.")
public boolean disableLegacyFlagsCcToolchainApi;

@Option(
name = "incompatible_enable_legacy_cpp_toolchain_skylark_api",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.UNKNOWN},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE, OptionMetadataTag.DEPRECATED},
help = "Obsolete, no effect.")
public boolean enableLegacyToolchainStarlarkApi;

@Option(
name = "incompatible_disable_legacy_cpp_toolchain_skylark_api",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.UNKNOWN},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE, OptionMetadataTag.DEPRECATED},
help = "Obsolete, no effect.")
public boolean disableLegacyToolchainStarlarkApi;

@Option(
name = "incompatible_enable_profile_by_default",
defaultValue = "true",
Expand Down Expand Up @@ -616,14 +485,6 @@ public static final class AllCommandGraveyardOptions extends OptionsBase {
help = "No-op")
public boolean besBestEffort;

@Option(
name = "incompatible_disable_managed_directories",
defaultValue = "false",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.NO_OP},
help = "No-op")
public boolean incompatibleDisableManagedDirectories;

@Option(
name = "experimental_use_event_based_build_completion_status",
defaultValue = "true",
Expand Down

0 comments on commit 20528af

Please sign in to comment.