forked from bazelbuild/bazel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
$ bazel test
: always configure --run_under=//foo
for the exec con…
…figuration. Rationale: test actions run on exec platforms, not the target platform. Configuring a test action for the target platform and running it on the exec platform makes no sense. This reverts an earlier conversion of `--run_under` from the exec to target platform . The rationale there was: 1. Using the target configuration is consistent with `$ bazel run --run_under` 2. When running tests, bazel uploads both the run_under target and the test itself to the same machine. Therefore they should have the same config. We should address these points by: 1. Converting `$ bazel run --run_under` similarly(added a TODO) 2. Updating the default test runner similarly Fixes bazelbuild#22624. PiperOrigin-RevId: 657586281 Change-Id: I04e7d712015535caa84824a7cec0b79a663bcfbe
- Loading branch information
1 parent
201da64
commit b03e4c5
Showing
4 changed files
with
40 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters