Simple sync #148
Open
Simple sync #148
+310
−374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with the grapesy test suite and it is resulting in some unexpected exceptions in one of our tests and causing another test to hang. I might be able to look into this a little deeper tomorrow! |
|
@kazu-yamamoto FYI, it is unlikely that @FinleyMcIlwaine will have a chance to look at this again, as he is unfortunately no longer working with us on the |
|
@edsko Could you run the same test by yourself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@edsko @FinleyMcIlwaine This PR simplifies the syncing way between workers and the sender.
A worker must take care of window for its stream.
So, the sender need not to take care of window for streams and can concentrates on window for the connection.
You don't have to understand the code in detail.
I would like you to test this PR with your stress testings.