-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use generic ThreadKilled
#79
Conversation
By using a specific exception debugging of client code becomes easier: when we see a thread killed using `ThreadKilled`, it could come from anywhere, but when we see a thread killed using `KilledByHttp2ThreadPoolManager`, it can only come from one place.
CI timeout on Windows is I think not related to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea!
@edsko Don't worry about Windows stuff. |
Rebased and merged. |
@kazu-yamamoto I am working on #77 again, when I noticed http2/Network/HTTP2/Server/Worker.hs Line 171 in 366560b
Perhaps I should have changed that line as part of this PR? |
Yeah. Would you send another PR to fix this? |
Yup, #81. |
By using a specific exception debugging of client code becomes easier: when we see a thread killed using
ThreadKilled
, it could come from anywhere, but when we see a thread killed usingKilledByHttp2ThreadPoolManager
, it can only come from one place.