-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ k/k 1.31.0 rebase #92
Conversation
4969f43
to
ad2daa2
Compare
ad2daa2
to
b352bc4
Compare
LGTM label has been added. Git tree hash: fc304296f4af40b279cb31aec95cf54cddf06ee2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Rebase to 1.31.
Changes:
genclient:skipVerbs=list,watch
. If skipped, on our end we skip List, Watch and DeleteCollections. It should be just List and Watch. Need to fix this or redo our generatorsdef.Strict = false
as we (k/k) changed some tags where now they aregroup=
, meaning its not full key-value-pair. This passes the validation as its non-strict mode. This could have consequences that we miss some API groups in the future.In general, we should see how to make these generators closer to upstream v2 as now they are bespoke solutions. Or live with a bespoke solution. I would better invest time in refactoring them while we have time, and it's not a hard blocker for rebase.
Related issue(s)
Fixes #
Release Notes