Fix disk cache key collisions - #889
Open
kean wants to merge 1 commit into
Open
Conversation
Processor identifiers and the request components were concatenated without a separator, so different requests could produce the same disk cache key and be served the wrong processed image.
Owner
Author
|
This is a breaking change. I'd need a migration step to drop the current cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageProcessors.Composition.identifierandmakeDataCacheKey(for:)concatenated identifiers with no separator, so requests like["resize-", "largeblur"]and["resize-large", "blur"]produced the same disk cache key and the second one was served the first one's processed bytes. The same applied to theimageID/thumbnail/processors boundaries. The memory cache didn't have this bug, so the two cache layers disagreed.Both now join their components with a
+separator (always emitted, so empty components can't alias either).Note: this changes the on-disk cache key format, so existing disk cache entries become unreachable - they simply miss, get re-fetched, and are reclaimed by the normal
DataCachesweep.