feat: support purging all deleted projects at once - #115
Open
jirkasemmler wants to merge 1 commit into
Open
Conversation
`storage:deleted-projects-purge` required an explicit list of project IDs, so purging everything meant first collecting the IDs by hand. Accept `ALL` and let the command list the deleted projects itself via the Manage API, paginating and skipping the ones already purged. The argument description also said IDs were space-separated while the code has always split on commas; corrected, and the README section now documents the arguments, options and behaviour like the neighbouring commands do. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
storage:deleted-projects-purgeacceptsALLasprojectIdsand lists the deleted projects itself via the Manage API (paginated, skipping the ones already purged), instead of requiring a hand-collected list of IDs.projectIdsargument description: it claimed IDs were space-separated, while the code has always split on commas.--ignore-backend-errorswas listed twice).Additional notes
Heads-up: CI on
mainis already failing at c4ef6b4 for an unrelated reason - phpstan reports 4 errors inFlowMigration/ProjectClientsFactory.php, caused by #111 (manage-api client^10) landing alongside #113 (FlowMigration); both were green on their own. This PR does not change that count: 4 before, 4 after. Locally phpunit (76 tests) and phpcs are green.🤖 Generated with Claude Code