Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RBAC namespace selection for metrics server #674

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

Rotzke
Copy link
Contributor

@Rotzke Rotzke commented Aug 5, 2024

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #645

@Rotzke Rotzke requested a review from a team as a code owner August 5, 2024 13:41
@Rotzke
Copy link
Contributor Author

Rotzke commented Aug 5, 2024

Hi @JorTurFer ! I have made a duplicate of #657 because it is stuck since the 28. of June and I was actually the one who requested the feature, please review my MR, I excluded version changes as you requested in the initial MR.

@JorTurFer
Copy link
Member

To make users 100% aware of the goal, we could call the parameter like controlPlaneServiceAccountsNamespace. I know that there are docs where it's explained how to enable the control plane permission segregation that spread the permissions in multiple service account, but I can't find it (it's a control plane argument). If you find it, I think that it's a good idea adding the link

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
@Rotzke
Copy link
Contributor Author

Rotzke commented Sep 3, 2024

To make users 100% aware of the goal, we could call the parameter like controlPlaneServiceAccountsNamespace. I know that there are docs where it's explained how to enable the control plane permission segregation that spread the permissions in multiple service account, but I can't find it (it's a control plane argument). If you find it, I think that it's a good idea adding the link

@JorTurFer I have renamed the variables, haven't really found those docs you mentioned, though it is not a command line argument for any of control plane components, I guess. Can we still get this merged into the next release/minor/patch version? Would be really cool, we are shivering in anticipation, waited for some time. Thanks in advance!

@JorTurFer
Copy link
Member

Can we still get this merged into the next release/minor/patch version?

Yeah! just let me look for the link a few days more and definitively this will be included for next version

keda/README.md Outdated Show resolved Hide resolved
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
@wozniakjan wozniakjan merged commit 86cd9b1 into kedacore:main Oct 14, 2024
36 checks passed
wozniakjan pushed a commit that referenced this pull request Oct 14, 2024
* Added required namespace variable and values file entry, updated docs

Signed-off-by: Nils <kurt.rotzke@gmail.com>

* Added required namespace variable and values file entry, updated docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

* Updated helm-docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

* Updated helm-docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

* Updated helm-docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

* Updated helm-docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

* Updated helm-docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

* Updated helm-docs

Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>

---------

Signed-off-by: Nils <kurt.rotzke@gmail.com>
Signed-off-by: Nils Bergmüller <kurt.rotzke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow metrics-server non-kube-system RBAC (+ClusterRole) deployment
4 participants