-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved HuggingFace Connectors #612
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
from typing import Any | ||
from kedro.io import AbstractDataset | ||
from transformers import AutoTokenizer, AutoModel | ||
|
||
import logging | ||
import importlib | ||
|
||
from collections import namedtuple | ||
|
||
|
||
TransformerModel = namedtuple("TransformerModel", ["model", "tokenizer"]) | ||
|
||
|
||
logger = logging.getLogger(__file__) | ||
|
||
|
||
class HFTransformer(AbstractDataset): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about (About There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, I'd prefer to keep it consistent even this isn't technically a dataset. |
||
def __init__( | ||
self, | ||
checkpoint: str, | ||
model_type: str = None, | ||
tokenizer_kwargs: dict = None, | ||
model_kwargs: dict = None, | ||
): | ||
self.checkpoint = checkpoint | ||
|
||
if model_type is not None: | ||
try: | ||
self.model = importlib.import_module(model_type, package='transformers') | ||
except ImportError as e: | ||
logger.info( | ||
f"Given model type={model_type} doesn't exist in transformers" | ||
) | ||
raise e | ||
else: | ||
self.model = AutoModel | ||
|
||
self.tokenizer_kwargs = tokenizer_kwargs | ||
self.model_kwargs = model_kwargs | ||
|
||
def _load(self) -> TransformerModel: | ||
model = self.model.from_pretrained(self.checkpoint, **self.model_kwargs) | ||
tokenizer = AutoTokenizer.from_pretrained(self.checkpoint, **self.tokenizer_kwargs) | ||
|
||
return TransformerModel(model=model, tokenizer=tokenizer) | ||
|
||
def _save(self, data) -> None: | ||
raise NotImplementedError("Pretrained models don't support saving for now") | ||
|
||
def _describe(self) -> dict[str, Any]: | ||
return { | ||
"checkpoint": self.checkpoint, | ||
"model_type": self.model, | ||
"tokenizer_kwargs": self.tokenizer_kwargs, | ||
"model_kwargs": self.model_kwargs, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this branching here is kind of unusual. As an alternative,
kedro-mlflow
provides 2 different datasets for this purpose,MlflowModelTrackingDataset
andMlflowModelLocalFileSystemDataset
. Do you think we should do the same here @merelcht ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes looking at this it might be an idea to split this into a dataset that does loading & saving to disk and one that does it remotely.