Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat(rpc): Add encode/decode to state diff field #1327

Closed
antiyro opened this issue Dec 23, 2023 · 3 comments
Closed

feat(rpc): Add encode/decode to state diff field #1327

antiyro opened this issue Dec 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@antiyro
Copy link
Contributor

antiyro commented Dec 23, 2023

feat: Implement Encode/Decode Trait for StateDiff Field

A new StateDiff field has been introduced in InvokeTransactionTrace, DeployAccountTransactionTrace, L1HandlerTransactionTrace, and DeclareTransactionTrace to address issue #1313.

Currently, this field lacks the implementation of the encode/decode trait, which is essential for its correct integration into the respective structures. This deficiency is highlighted by the following error:

the trait bound `[starknet_core::types::StateDiff]: Encode` is not satisfied

To resolve this, a comprehensive implementation of the StateDiff with encodable and decodable components is necessary. This implementation should adhere to the established schema in starknet-rs, thereby aligning with the JSON-RPC specifications.

@antiyro antiyro added the enhancement New feature or request label Dec 23, 2023
@antiyro antiyro changed the title feat: Add encode/decode to state diff field feat(rpc): Add encode/decode to state diff field Dec 23, 2023
@antiyro
Copy link
Contributor Author

antiyro commented Dec 23, 2023

I'm taking this one

@antiyro
Copy link
Contributor Author

antiyro commented Dec 25, 2023

Closing this issue as it is solved here: 5641578 and about to be merged here #1313

@antiyro
Copy link
Contributor Author

antiyro commented Dec 25, 2023

Note that this issue is linked to this one: #1331

@antiyro antiyro closed this as completed Dec 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant