This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
feat(rpc) implemented v0.5.1 missing fields + bumped starknet.rs to match #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/rpc-0.5.1
|
Some problems in this PR are still to be solved because of new fields/impl in starknet.rs:
Implies changes in starknet-api. More to be identified. |
This was referenced Dec 22, 2023
…into feat/rpc-0.5.1
tdelabro
suggested changes
Jan 5, 2024
This was referenced Jan 6, 2024
tdelabro
reviewed
Jan 8, 2024
tdelabro
suggested changes
Jan 8, 2024
…into feat/rpc-0.5.1
…to feat/rpc-0.5.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(rpc) implemented v0.5.1 missing fields + bumped starknet.rs to match
This pull request is to update the Madara code base to the latest version of RPC specs v0.5.1 as defined in here starknet api json. To achieve this, it was necessary to bump starknet.rs version to 64ebc36 commit in starknet-api and blockifier.
The fields
l1_gas_price,message_hash,execution_resourceshas been defaulted since they're beeing implemented hereThis pull request does not implement any changes but is needed to solve the v0.5.1 madara rpc upgrade