This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Rails 4.0 Upgrade #59
Open
kennethkalmer
wants to merge
31
commits into
master
Choose a base branch
from
rails-4-0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y`, `be_true`, `be_false`. also refactored a few specs to use subject
This reverts commit 079a2af.
This conversion is done by Transpec 3.0.7 with the following command: transpec * 443 conversions from: obj.should to: expect(obj).to * 128 conversions from: obj.should_not to: expect(obj).not_to * 25 conversions from: be_true to: be_truthy * 22 conversions from: == expected to: eq(expected) * 7 conversions from: be_false to: be_falsey * 2 conversions from: > expected to: be > expected * 2 conversions from: lambda { }.should to: expect { }.to * 1 conversion from: < expected to: be < expected * 1 conversion from: lambda { }.should_not to: expect { }.not_to * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: pending to: skip * 1 conversion from: pending 'is an example' { } to: skip 'is an example' { } * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic work to get us running on Rails 4.0, as is