Add Windows guest control and ConPTY - #431
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
c5bc68c to
0d96de5
Compare
0d96de5 to
73fd1af
Compare
73fd1af to
7cd7a6e
Compare
0c1d3e4 to
1487012
Compare
1487012 to
96a8dd9
Compare
96a8dd9 to
38cabf0
Compare
38cabf0 to
0886125
Compare
1f60d0a to
95cf15f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a0a4c9a. Configure here.
| }) | ||
| require.NoError(t, err, stderr.String()) | ||
| require.Equal(t, 0, exit.Code) | ||
| assert.Contains(t, stdout.String(), "HYPEMAN_DESKTOP_OK") |
There was a problem hiding this comment.
Desktop station check removed
Medium Severity
The desktop-session integration check now only asserts that a DESKTOP exec can echo output. It no longer verifies the process lands on WinSta0\Default, which is the defining property of desktop sessions for UI visibility. A regression that obtains a user token but fails to bind the interactive desktop would still pass this gate.
Reviewed by Cursor Bugbot for commit a0a4c9a. Configure here.


summary
Runningwhen guest-agent readiness is provenlib/system/README.mdtargeted tests
The dedicated Windows guest-control KVM gate and full Linux, Darwin, and install suites pass. Runtime terminal resize and additional signal-parity work are intentionally deferred.
Note
High Risk
Touches guest exec protocol, Windows process/token handling, vsock transport, and instance readiness, so bugs can affect command isolation, desktop session access, and when Windows VMs become Running.
Overview
Windows guests now run the existing gRPC guest-agent over virtio-win VioSock as a LocalSystem service (
hypeman-guest-agent.exe), instead of skipping the agent.Exec gains an explicit
session(systemvsdesktop). SYSTEM uses ConPTY for TTY; desktop launches into the active interactive session onwinsta0\defaultand rejects ConPTY. Commands start suspended, join a kill-on-close Job Object, then resume so timeouts and RPC close kill the whole tree. Copy/stat/shutdown work on Windows; network reconfigure is unimplemented.Host-side, Windows instances no longer force
SkipGuestAgent. They becomeRunningwhen a guest-agent probe succeeds (usingcmd.exeinstead of/bin/true). CI builds the Windows agent and adds a QEMU guest-control integration gate.Reviewed by Cursor Bugbot for commit a0a4c9a. Bugbot is set up for automated code reviews on this repo. Configure here.