Memoize Playwright page target IDs - #356
Conversation
masnwilliams
left a comment
There was a problem hiding this comment.
reviewed the stacked layer at 16d6b3a. one root CDP session per attempt removes the nested session churn, while the weak cache is refreshed on retry and reset on browser disconnect/timeout. the cache tests cover reuse, failed discovery, refresh, in-flight work, and reset.
validation beyond BugBot: runtime tests and the full non-e2e race suite pass; both Dockerfiles pass build checks; the bundled daemon passed the deterministic cross-context case, 30 rapid cross-origin transitions with no failures/wrong pages, page recreation, and an unmatched raw-CDP tab. with 41 pages, warm active-first/active-last resolution was ~10ms in both positions.
this PR targets the lower stack branch, so the main-targeted image/server workflows have not run on this layer yet. please let those run after #347 merges and this retargets to main, before merging/releasing. approved subject to that normal CI gate.
16d6b3a to
38956b2
Compare
Summary
Stack
Based on #347. Replaces #352/#355 after the
resolve_active_pagerequest option was dropped from the stack.Validation
make test-runtime(9/9)go vet ./...