Model100: Enable the AutoShift & AutoShiftConfig plugins by default #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the slice given to AutoShiftConfig is uninitialized, leave it alone, do not save defaults there. Saving the defaults there would prevent us from setting up a sketch that defaults to the plugin being off, while still allowing it to be turned on, and persisting that setting. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
The AutoShift plugin is enabled by default, but when using AutoShiftConfig, we may want to have it disabled by default, so that we can include it in firmware updates without turning optional, behaviour changing features on by default. The new method helps us accomplish this, in a way similar to how SpaceCadet accomplishes the same thing. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
This changes the EEPROM layout. Fixes the Kaleidoscope parts of keyboardio/Chrysalis#681. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
algernon
force-pushed
the
b/autoshift/enable-for-the-model100
branch
from
16553b8
to
b37f829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the EEPROM layout!
Fixes the Kaleidoscope parts of keyboardio/Chrysalis#681.
Depends on (and includes) #1302.
Because this changes the EEPROM layout, we may want to delay merging this until we've ironed out a few more of the Chrysalis flashing issues. Setting this as a draft for that reason.