Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

(feat) adds azure cdn support + tests #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cadriel
Copy link

@cadriel cadriel commented Nov 22, 2017

This adds;

  • The ability to define a custom domain. If set, this changes the host of the returned function getUrl. Mostly this is handy when using CDN's as they usually have a different domain.
  • The ability to set cache control for Azure uploads. By default, these are not set in this adapter - so I've added the ability to do so. This is REALLY important for CDN's, but should probably be set in any case.
  • The ability to set purging on and off for Azure CDN's. Unfortunately (unlike Akamai) Azure do not auto purge on overwrite or delete. This adds the ability to toggle purging on, and configure the required credentials to do so.

I've also added a .editorconfig for sanity's sake.

Finally - the tests in master were not working, nor relevant for the code. I have re-written a suite of unit tests.

@cadriel
Copy link
Author

cadriel commented Nov 22, 2017

@wmertens @jossmac @JedWatson

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants