Allow registering fully closed generic types, even if arity doesn't m…

…atch #104
khellang · Sep 25, 2024 · 481f71b · 481f71b
1 parent 5221bff
commit 481f71b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Scrutor/ReflectionExtensions.cs b/src/Scrutor/ReflectionExtensions.cs
@@ -234,6 +234,11 @@ public static bool HasMatchingGenericArity(this Type interfaceType, Type type)
         {
             if (interfaceType.IsGenericType)
             {
+                if (!interfaceType.ContainsGenericParameters)
+                {
+                    return true;
+                }
+
                 var argumentCount = interfaceType.GetGenericArguments().Length;
                 var parameterCount = type.GetGenericArguments().Length;
 

diff --git a/test/Scrutor.Tests/ScanningTests.cs b/test/Scrutor.Tests/ScanningTests.cs
@@ -220,6 +220,19 @@ public void CanRegisterGenericTypes()
             Assert.Equal(typeof(QueryHandler), service.ImplementationType);
         }
 
+        [Fact]
+        public void CanRegisterFullyClosedGenericWithDifferentArityThanServiceType()
+        {
+            Collection.Scan(scan => scan
+                .FromTypes(typeof(PartiallyClosedGeneric<string>))
+                .AsImplementedInterfaces()
+                .WithTransientLifetime());
+
+            var descriptor = Assert.Single(Collection);
+
+            Assert.Equal(typeof(IPartiallyClosedGeneric<string, int>), descriptor.ServiceType);
+        }
+
         [Fact]
         public void CanScanUsingAttributes()
         {